chore: add generation step for commit#13337
Open
sofisl wants to merge 7 commits into
Open
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
zhumin8
reviewed
Jun 3, 2026
| fi | ||
| - name: Commit and Create PR | ||
| if: steps.detect.outputs.has_changes == 'true' | ||
| if: steps.detect_librarian.outputs.has_changes == 'true' || steps.generate.outputs.has_changes == 'true' |
Contributor
There was a problem hiding this comment.
can we create 2 separate commits, one for config change, and one for generated code change?
Contributor
Author
There was a problem hiding this comment.
Hm not sure I follow, the config change one existed previously - I'm just renaming it so it's less confusing. Do you want me to revert the name to detect?
Contributor
There was a problem hiding this comment.
In the PR that this workflow creates, the code change contains 1) change to librarian.yaml 2) change to generated code. Let's create separate commit for these in the PR.
This can be a follow up.
zhumin8
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a step to generate libraries when changing a librarian.yaml workflow
Fixes #6219